Repository navigation
Correctly apply the end-of-contents octets to the right level - #134
Merged
Lukasa merged 1 commit intoOct 8, 2026
Merged
Conversation
Motivation In #125 we attempted to apply a hardening fix that would avoid allowing truncation of BER content by applying an end-of-contents octets at the wrong parse depth to a higher-level object. This fix was incomplete. Modifications Re-write the code to handle the end-of-contents octets as part of the loop instead of attempting to detect it after the fact. Add defense-in-depth for unexpected nodes. Results More robust against issues with end-of-contents octets.
simonjbeaumont
approved these changes
Oct 8, 2026
Lukasa
deleted the
cb-correctly-associate-indefinitely-length-end-sequence
branch
October 8, 2026 12:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In #125 we attempted to apply a hardening fix that would avoid allowing truncation of BER content by applying an end-of-contents octets at the wrong parse depth to a higher-level object. This fix was incomplete.
Modifications
Re-write the code to handle the end-of-contents octets as part of the loop instead of attempting to detect it after the fact. Add defense-in-depth for unexpected nodes.
Results
More robust against issues with end-of-contents octets.