Repository navigation
Throw on truncated BER indefinite length encodings - #127
Merged
Lukasa merged 2 commits intoAug 13, 2026
Merged
Conversation
Motivation: A truncated BER indefinite length constructed value was treated as success. The last child was popped and used as the end of contents marker, which silently dropped data. Modifications: Require an end of contents marker after the indefinite length parse loop and throw truncatedASN1Field when it is missing. Add a regression test for the truncated and complete encodings. Result: Truncated BER indefinite length input fails instead of dropping the last child.
Lukasa
approved these changes
Aug 13, 2026
Lukasa
left a comment
Lukasa
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this, this looks very nice!
Lukasa
enabled auto-merge (squash)
August 13, 2026 14:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #125
A truncated BER indefinite length constructed value was parsed as success. The last child was popped and treated as the end of contents marker, so that child disappeared.
The parser now throws truncatedASN1Field when input ends without those octets, matching X.690 section 8.1.3.6.1.
Test plan
Added testRejectsTruncatedBERIndefiniteLengthWithoutEndMarker. Built the SwiftASN1 product. Full XCTest suite needs Xcode.