Repository navigation
http-netty: ON_NEW_CONNECTION discovery ignores proxy config - #3682
Merged
Merged
Conversation
Motivation: With `DiscoveryStrategy.ON_NEW_CONNECTION`, the connection factory always resolved the origin address captured at build time, even when it was given the proxy address. Clients with a proxy configured connected directly to the origin server instead. Modifications: - Map the resolved address back with `r -> (U) r` instead of returning the captured origin address. - Add proxy tests in `HttpProxyTest` and `HttpsProxyTest` that run with each `DiscoveryStrategy`. Result: Clients that use `ON_NEW_CONNECTION` strategy with a custom service discoverer send traffic through the configured proxy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
With
DiscoveryStrategy.ON_NEW_CONNECTION, the connection factory always resolved the origin address captured at build time, even when it was given the proxy address. Clients with a proxy configured connected directly to the origin server instead.Modifications:
r -> (U) rinstead of returning the captured origin address.HttpProxyTestandHttpsProxyTestthat run with eachDiscoveryStrategy.Result:
Clients that use
ON_NEW_CONNECTIONstrategy with a custom service discoverer send traffic through the configured proxy.