Repository navigation
Resolve properties within annotation bodies - #256
Merged
Merged
Conversation
bioball
reviewed
Oct 7, 2026
mimischi
force-pushed
the
annotation-body-definition
branch
from
October 8, 2026 08:44
945d6cf to
e96d9a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go to definition and hover on a property inside an annotation body, like
languagein@SourceCode { language = "Pkl" }, resolved to theannotation class instead of the property. The
PklDeclaredTypeImplofan annotation spans the whole annotation including its body, so
findBySpan()never made it down to the property.While adding tests for it, I noticed
testhas only been running thesnippet tests since #33, so
GoToDefinitionTest,HoverTestand friends never ran in CI. Fixed thattoo, otherwise the new tests would not run either.