Repository navigation
Remove dead blob granule leftovers from the C header and Java tests - #14246
Merged
saintstack merged 1 commit intoOct 8, 2026
Merged
Conversation
Blob granules were removed in 8.0. The FDBBG* file-description types in fdb_c.h were only consumed by the removed read-blob-granules description API, and the static_asserts in fdb_c.cpp only checked their enum against MutationRef. API_TEST_BLOB_GRANULES_ENABLED is no longer an option of add_fdbclient_test, so CMake was silently ignoring it. FDBGranuleSummary and FDBReadBlobGranuleContext are kept: the abort stubs that let older multiversion clients load this library use them.
Contributor
Result of foundationdb-pr-clang-ide on Linux RHEL 9
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Result of foundationdb-pr on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-macos-m1 on macOS 14.x
|
Contributor
Result of foundationdb-pr-clang on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-clang-arm on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-macos on macOS 14.x
|
ploxiln
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blob granules were removed in 8.0, but a few dead leftovers remain:
fdb_c.hstill definesFDBBGMutationTypeand theFDBBG*file-description structs (tenant prefix, encryption key/context, file pointer, mutation, file description). Only the removed read-blob-granules description API used them.fdb_c.cppstill hasstatic_asserts that checkFDB_BG_MUTATION_TYPE_*againstMutationRef::Type.bindings/java/CMakeLists.txtpassesAPI_TEST_BLOB_GRANULES_ENABLEDto twoadd_fdbclient_testcalls. That option is no longer declared incmake/AddFdbTest.cmake, so CMake silently ignores it.Delete them (deletions only).
FDBGranuleSummaryandFDBReadBlobGranuleContextare kept, because the stubs that let older multiversion clients load this library use them (#14238). The API-version and protocol-version blob granule features are also left in place as version history.