Repository navigation
Conversation
Replace the `sphinx-bootstrap-theme` with the `shibuya` theme and update the Sphinx configuration accordingly: - Set `html_theme` to `"shibuya"` - Set `html_logo` to `"../FDB_logo.svg"` - Drop the `sphinx_bootstrap_theme` import - Drop the `sphinxcontrib.jquery` extension - Drop the bootstrap-specific theme options - Add `discussion_url`/`github_url` social links - Add the "Edit this page" link in `html_context`
Author
Contributor
|
@hwhsu1231 Why should we do this? Thank you. |
Author
@saintstack There are various factors:
|
Author
|
Additionally, if time permits later on, I also plan to use widgets from the sphinx-design extension (such as grids, cards, buttons, etc.) to improve the documentation. |
Contributor
|
@hwhsu1231 Thank you. For a change like this, the way the docs look, I'd suggest bringing it up on fdb forum and/or over in discord just to give folks prior-notice. Talk up the benefits and link to images of what it'll look like. Thanks. |
Contributor
|
@hwhsu1231 Thanks for posting. Lets see if any feedback. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Replace the
sphinx-bootstrap-themewith theshibuyatheme and update the Sphinx configuration accordingly:html_themeto"shibuya"html_logoto"../FDB_logo.svg"sphinx_bootstrap_themeimportsphinxcontrib.jqueryextensiondiscussion_url/github_urlsocial linkshtml_context