Repository navigation
docs: lazy-load light/dark images so the hidden one isn't fetched - #275
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #222 (comment)
The docs show a light and a dark version of the same image and hide one of them with
.light-only/.dark-only(display: none). The browser still downloads the hidden one. On the overview, tool, embedding-view and embedding-view-mosaic pages that's an extra ~2 MB png per page, and the examples page fetches 9 extra thumbnails.This adds
loading="lazy"to those images. A lazy image withdisplay: noneisn't loaded, so only the visible version is fetched, and the other one loads when you switch the theme. I checked it in Chrome with the same markup and css: in light mode the dark images are no longer requested, and switching to dark loads them.On overview and tool the visible image is near the top of the page, so lazy can start it a little later, but that seemed better than downloading 2 MB that isn't shown.