Repository navigation
Conversation
…e and gather_mm - Add rope_externalize_spec and gathermm_externalize_spec with CompositeRoPEModel and CompositeGatherMMModel - Parameterize test_composite_op_survives_prepare_and_finalize across SDPA, RoPE, and GatherMM for w8 and w8a8 quantization modes - Parameterize test_composite_boundary_quantized and test_composite_boundary_input_index_selects_those_args for multi-input composite ops - Extract reusable sample tensor generators to keep test tables clean and maintainable
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expands test coverage in
tests/quantization/test_composite_op_externalize.pyto coverRoPEandGatherMMfromcoreai_torch.composite_ops, which were previously only exercised withSDPAandRMSNorm.CompositeRoPEModelandCompositeGatherMMModelalong with theirExternalizeSpechelpers intests/models/composite.py.test_composite_op_survives_prepare_and_finalizeacross SDPA, RoPE, and GatherMM for both weight-only and w8a8 quantization.test_composite_boundary_quantizedandtest_composite_boundary_input_index_selects_those_argsto ensure multi-tensor inputs handle selective input port boundary quantization correctly._single_tensor_sample,_rope_sample,_gather_mm_sample) to keep test fixtures clean.Tested with
pytest tests/quantization/test_composite_op_externalize.py(20 passed) andmake check.