Repository navigation
Conversation
The pipelined engine's constrained-encode step built its async state views with only the growing key/value cache and omitted additionalStates, so bundles that declare more than two states (e.g. Muse Glimmer's sliding-ring key/value pair) failed the first constrained encode with "Missing state view". Bind additionalStates the same way the plain-decode and prefill paths do. It is a no-op for standard two-state models, so existing bundles are unaffected. Fixes apple#316.
stikves
force-pushed
the
sukru/fix-issue-316
branch
from
October 10, 2026 23:19
a0310b5 to
fb20a47
Compare
stikves
marked this pull request as ready for review
October 10, 2026 23:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #316.
Bind
additionalStateson the pipelined constrained-encode path (matching theplain-decode and prefill paths), so bundles that declare more than two states —
e.g. sliding-ring key/value caches — no longer fail the first constrained encode
with "Missing state view". No-op for standard two-state bundles.