Repository navigation
Run ruff check and format on models/ with the same rules as python/ - #336
Merged
Merged
Conversation
models/ had no ruff config, so ruff used its defaults there (88 columns and a smaller rule set) and CI never looked at it. Add models/ruff.toml that extends python/pyproject.toml, add models/ to the CI lint job, and bring the existing export scripts in line: - format with the shared 100-column limit - apply the autofixes (Optional[X] -> X | None, import order) - wrap the over-long model description and --include-debug-info help strings; string values are unchanged
tjia1818
requested review from
Lewis300,
carinapeng,
kevchengcodes and
stikves
October 9, 2026 17:11
kevchengcodes
approved these changes
Oct 9, 2026
kevchengcodes
left a comment
kevchengcodes
left a comment
Contributor
There was a problem hiding this comment.
thanks for adding this!
stikves
approved these changes
Oct 9, 2026
carinapeng
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
models/ had no ruff config, so ruff used its defaults there (88 columns and a smaller rule set) and CI never looked at it. Add models/ruff.toml that extends python/pyproject.toml, add models/ to the CI lint job, and bring the existing export scripts in line: