Repository navigation
Conversation
The CloudHypervisor types now model these fields of the Cloud Hypervisor OpenAPI spec (present since before v52.0): - CpusConfig.features (CpuFeatures, with amx) - CpusConfig.core_scheduling (CoreSchedulingMode: Vm, Vcpu, Off) - CpusConfig.nested - MemoryConfig.hugepages - MemoryConfig.prefault All are optional and nil by default, and nil fields are not encoded, so the JSON for an existing configuration does not change. A CHInstanceExtension can set them in configureCH.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CloudHypervisortypes now model these fields of the Cloud Hypervisor OpenAPI spec (present since before v52.0):CpusConfig.features(CpuFeatures, withamx)CpusConfig.core_scheduling(CoreSchedulingMode:Vm,Vcpu,Off)CpusConfig.nestedMemoryConfig.hugepagesMemoryConfig.prefaultAll are optional and nil by default, and nil fields are not encoded, so the JSON for an existing configuration does not change. A
CHInstanceExtensioncan set them inconfigureCH.Tests
TypesTests: the new fields encode with the OpenAPI keys and round-trip; nil fields are omitted.