fix: update insets and frame on window resize on web - #736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
windowresizelistener to the webNativeSafeAreaProviderthat calls the existing measurement handler (removed on effect cleanup). Insets and frame were only re-measured on the hidden element's CSStransitionend, which a plain window resize never fires, souseSafeAreaFrameanduseSafeAreaInsetsstayed stale after mount.Fixes #184
Test Plan
Added
src/__tests__/NativeSafeAreaProvider.web-test.tsx(jsdom): renders the web provider with stubbed computed paddings and document dimensions, dispatches aresizeevent, and assertsonInsetsChangereports the new frame and insets. Fails without the fix (onInsetsChangenever called after resize), passes with it.jest-environment-jsdomis added as a devDependency (Jest 29 doesn't bundle it) — that's all the yarn.lock churn.