Repository navigation
fix: Match modules whose id has a query - #53
Merged
Merged
Conversation
Vite's dev server loads a dependency that it does not pre-bundle as `<file>?v=<hash>`. The raw id went to `moduleDetailsFromPath()` and `detectModuleType()`, so the path did not match the configured `filePath`, and the module was not transformed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JPeer264
marked this pull request as ready for review
October 27, 2026 19:06
isaacs
requested review from
AbhiPrasad,
Qard,
bengl,
bizob2828,
jsumners-nr and
timfish
October 28, 2026 17:05
Contributor
|
Would be good to get a non-Sentry pair of eyes on this, if possible. 🙏 |
timfish
approved these changes
Oct 28, 2026
AbhiPrasad
approved these changes
Oct 28, 2026
Contributor
|
Close enough ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #52
Description
This removes the query and the hash from the module id before the module is matched. A dependency that Vite's dev server loads as
<file>?v=<hash>is now transformed.transform()already used the stripped path forsourceFile.