Repository navigation
Conversation
ApiMap#get_method_stack and #inner_get_methods parsed their inference-derived rooted_tag with ComplexType.parse, so a type Solargraph reconstructed badly raised ComplexTypeError through Chain#infer and aborted the whole typecheck run. Use try_parse, as the sibling #get_methods already does: the tag resolves to undefined and the caller gets an empty method stack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude: This PR was written by Claude Code on behalf of @apiology.
Problem
A badly formed method tag raises instead of finding no methods:
The tag comes from inference, so one type Solargraph rebuilds wrongly aborts a whole
solargraph typecheckrun instead of affecting one file.Solution
Parse the tag with
ComplexType.try_parseinApiMap#get_method_stackand#inner_get_methods, as the sibling#get_methodsalready does, so it resolves to undefined and returns an empty method stack.Extracted from castwide/solargraph#1231, intersection types.