Repository navigation
Conversation
RBS types Kernel#<=> as 0?, the exact result of Object's own implementation. A <=> defined without a return type borrows that through typify_from_super, so ActiveRecord::Core#<=> (untyped in the RBS collection) resolves to 0, nil wherever literal types are kept. Override it with the comparison contract until ruby/rbs#3210 ships. The override is an @overload with one parameter so it replaces the RBS signature of the same arity instead of adding a second one. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EhUSLUimEYJyCZv8NdQGKb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude: This PR was written by Claude Code on behalf of @apiology.
Problem: Any
<=>without its own return type resolves to0, nil.RBS types
Kernel#<=>as0?,Object's own result, so every undeclared override (ActiveRecord::Core#<=>among them) inherits a type that rules out-1and1wherever literal types are kept.Solution: Override
Kernel#<=>in the core fills to returnInteger, nil, as an@overloadwith one parameter so it replaces the RBS signature instead of adding a second, until ruby/rbs#3210 ships.Builds on castwide#1104, which makes overrides apply to RBS methods and keep multi-type returns.