Skip to content

Annotate models + Order scope bug - #31

Open
sohaibbhatti wants to merge 2 commits into
apigy:masterfrom
sohaibbhatti:fix_order_scope_bug
Open

Annotate models + Order scope bug#31
sohaibbhatti wants to merge 2 commits into
apigy:masterfrom
sohaibbhatti:fix_order_scope_bug

Conversation

@sohaibbhatti

Copy link
Copy Markdown

This Pull Request serves two purposes

Adding Annotate Models

In the code base, all models and specs have their attributes and corresponding datatypes in the form of comments. This makes development for developers easier by serving as a visual cue.

Fixed a Bug in the order completed scope

Prior to this, the Order.completed scope was returning the following SQL.

   SELECT "orders".* FROM "orders" WHERE (token != '' OR token != NULL)

The SQL is incorrect because logical operations on NULL will always result in a NULL. i.e. (NULL = NULL would yield a NULL). It has now been fixed to

   SELECT "orders".* FROM "orders" WHERE (token != '' OR token IS NOT NULL)

Sohaib Bhatti added 2 commits February 9, 2013 22:25
DavidMMelin referenced this pull request in DavidMMelin/craftcrate Jul 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant