Skip to content

Fix IgnoreXSIType and UseGrammarPoolOnly test assertions (VALIDATION_NONE -> VALIDATION_PARTIAL) #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elharo wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix IgnoreXSIType and UseGrammarPoolOnly test assertions (VALIDATION_NONE -> VALIDATION_PARTIAL) #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79e45c3
Fix schema config test assertions (VALIDATION_NONE -> VALIDATION_PART…
elharo Jul 17, 2026
86e126c
Fix indentation and merge branch 'main' into fix-commented-out-tests
elharo Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions build.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,18 +837,18 @@ Authors:
<include name="schema/config/RootSimpleTypeDefinitionTest.class"/>
<include name="schema/config/RootTypeDefinitionTest.class"/>
<include name="schema/config/UseGrammarPoolOnly_False_Test.class"/>
<!-- These tests are failing. Fix them.
<include name="schema/config/IgnoreXSIType_C_AC_Test.class"/>
<include name="schema/config/IgnoreXSIType_C_CA_Test.class"/>
<include name="schema/config/IgnoreXSIType_C_C_Test.class"/>
<include name="schema/config/SurrogatePairLengthTest.class"/>
<include name="schema/config/UseGrammarPoolOnly_True_Test.class"/>
<include name="schema/Test.class"/>
<!-- These tests still need fixes:
<include name="schema/config/UnparsedEntityCheckingTest.class"/>
-->
<include name="schema/Test.class"/>
<include name="jaxp/JAXPSpecTest.class"/>
<include name="dom/ids/Test.class"/>
</fileset>
<include name="schema/config/SurrogatePairLengthTest.class"/>
-->
<include name="jaxp/JAXPSpecTest.class"/>
<include name="dom/ids/Test.class"/>
</fileset>
</batchtest>


Expand Down
2 changes: 1 addition & 1 deletion tests/schema/config/IgnoreXSIType_C_AC_Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ private void checkTrueResult() {

child = super.getChild(2);
assertValidity(ItemPSVI.VALIDITY_NOTKNOWN, child.getValidity());
assertValidationAttempted(ItemPSVI.VALIDATION_NONE, child
assertValidationAttempted(ItemPSVI.VALIDATION_PARTIAL, child
.getValidationAttempted());
assertElementNull(child.getElementDeclaration());
assertAnyType(child.getTypeDefinition());
Expand Down
2 changes: 1 addition & 1 deletion tests/schema/config/IgnoreXSIType_C_CA_Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ private void checkTrueResult() {

PSVIElementNSImpl child = super.getChild(1);
assertValidity(ItemPSVI.VALIDITY_NOTKNOWN, child.getValidity());
assertValidationAttempted(ItemPSVI.VALIDATION_NONE, child
assertValidationAttempted(ItemPSVI.VALIDATION_PARTIAL, child
.getValidationAttempted());
assertElementNull(child.getElementDeclaration());
assertAnyType(child.getTypeDefinition());
Expand Down
4 changes: 2 additions & 2 deletions tests/schema/config/IgnoreXSIType_C_C_Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,14 +129,14 @@ public void testSetTrueFragment() {

private void checkTrueResult() {
assertValidity(ItemPSVI.VALIDITY_NOTKNOWN, fRootNode.getValidity());
assertValidationAttempted(ItemPSVI.VALIDATION_NONE, fRootNode
assertValidationAttempted(ItemPSVI.VALIDATION_PARTIAL, fRootNode
.getValidationAttempted());
assertElementNull(fRootNode.getElementDeclaration());
assertAnyType(fRootNode.getTypeDefinition());

PSVIElementNSImpl child = super.getChild(1);
assertValidity(ItemPSVI.VALIDITY_NOTKNOWN, child.getValidity());
assertValidationAttempted(ItemPSVI.VALIDATION_NONE, child
assertValidationAttempted(ItemPSVI.VALIDATION_PARTIAL, child
.getValidationAttempted());
assertElementNull(child.getElementDeclaration());
assertAnyType(child.getTypeDefinition());
Expand Down
1 change: 0 additions & 1 deletion tests/schema/config/UnparsedEntityCheckingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ public void testDefaultValid() {
}

checkDefault();
throw new RuntimeException();
}

public void testSetFalseValid() {
Expand Down
2 changes: 1 addition & 1 deletion tests/schema/config/UseGrammarPoolOnly_True_Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public void testUsingOnlyGrammarPool() {
}

assertValidity(ItemPSVI.VALIDITY_NOTKNOWN, fRootNode.getValidity());
assertValidationAttempted(ItemPSVI.VALIDATION_NONE, fRootNode
assertValidationAttempted(ItemPSVI.VALIDATION_PARTIAL, fRootNode
.getValidationAttempted());
assertElementNull(fRootNode.getElementDeclaration());
assertAnyType(fRootNode.getTypeDefinition());
Expand Down
Loading