[kpumuk]

Ruby server threads appear unnamed in thread dumps, making it difficult to distinguish connection handlers, workers, and server helpers.

Name connection handlers thrift.threaded, pool workers thrift.pool.N, nonblocking workers thrift.nb.N, and helper threads thrift.server, thrift.io, and thrift.shutdown. Worker indexes start at zero for each server run and increase for replacements. Application-owned threads keep their names.

Examples

Live process/thread snapshots from the existing Ruby benchmark. Only workers 0–4 are shown; workers 5–19 are omitted.

ThreadPoolServer

ruby(9269) — ThreadPoolServer
├── {ruby}(9270)
├── {server.rb:88}(9271)
├── {thrift.pool.0}(9272)
├── {thrift.pool.1}(9273)
├── {thrift.pool.2}(9274)
├── {thrift.pool.3}(9275)
└── {thrift.pool.4}(9276)

NonblockingServer

ruby(9355) — NonblockingServer
├── {ruby}(9356)
├── {server.rb:88}(9357)
├── {thrift.io}(9358)
├── {thrift.nb.0}(9359)
├── {thrift.nb.1}(9360)
├── {thrift.nb.2}(9361)
├── {thrift.nb.3}(9362)
└── {thrift.nb.4}(9363)

The server.rb:88 thread is created by the benchmark harness.

• Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
• If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
• Did you squash your changes to a single commit? (not required, but preferred)
• Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
• If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

[Copilot]

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

3 open issues

• Thread#name=` is not available on all Ruby versions/configurations. If this library supports Ruby… · New
• Draining @threads via threads << @threads.pop until @threads.empty? can miss threads that get… · New
• This spec helper assumes Thread#name= exists. If the test suite runs on Ruby runtimes without… · New

What changed in this PR

This PR improves Ruby server observability by assigning meaningful names to Apache Thrift Ruby server threads, making thread dumps easier to interpret.

Changes:

• Name per-connection handler threads for Thrift::ThreadedServer (thrift.threaded).
• Name Thrift::ThreadPoolServer background server thread (thrift.server) and number worker threads (thrift.pool.N).
• Name Thrift::NonblockingServer helper threads (thrift.io, thrift.nb.N, thrift.shutdown) and add specs validating naming behavior.

File	Description
lib/​rb/​spec/​server_spec.rb	Adds thread-naming focused specs and adjusts existing thread stubs to match new Thread.new(arg) usage.
lib/​rb/​lib/​thrift/​server/​threaded_server.rb	Names connection handler threads as thrift.threaded.
lib/​rb/​lib/​thrift/​server/​thread_pool_server.rb	Names server thread thrift.server and pool workers thrift.pool.N with per-run indexing.
lib/​rb/​lib/​thrift/​server/​nonblocking_server.rb	Names nonblocking I/O (thrift.io), worker threads (thrift.nb.N), and async shutdown (thrift.shutdown).

_{Review effort: Lite}

[Copilot]

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

9 open issues

• As with the other servers, these thread-name assignments are unconditional and can raise… · New
• As with the other servers, these thread-name assignments are unconditional and can raise… · New
• As with the other servers, these thread-name assignments are unconditional and can raise… · New
• These unconditional Thread.current.name = ... calls can raise NoMethodError on Rubies without… · New
• These unconditional Thread.current.name = ... calls can raise NoMethodError on Rubies without… · New
• Thread#name= is not available on all Ruby implementations/versions; calling it unconditionally… · New
• The new specs assume Thread#name/Thread#name= exist and will fail on runtimes where thread… · New
• The new specs assume Thread#name/Thread#name= exist and will fail on runtimes where thread… · New
• Draining @threads via threads << @threads.pop until @threads.empty? can miss threads that get…

2 resolved since last review

• This spec helper assumes Thread#name= exists. If the test suite runs on Ruby runtimes without…
• Thread#name=` is not available on all Ruby versions/configurations. If this library supports Ruby…

_{Review effort: Lite}

[Copilot]

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

4 open issues

• To prevent potential NoMethodError on runtimes without Thread#name=, guard the thread naming… · New
• Similar to other thread naming sites, consider guarding Thread.current.name = ... behind… · New
• Thread#name= is not guaranteed to exist on all supported Ruby implementations/versions. To avoid… · New
• This stub will fail under RSpec verifying partial doubles if Thread#name= is not defined on the… · New

9 resolved since last review

• The new specs assume Thread#name/Thread#name= exist and will fail on runtimes where thread…
• The new specs assume Thread#name/Thread#name= exist and will fail on runtimes where thread…
• Thread#name= is not available on all Ruby implementations/versions; calling it unconditionally…
• These unconditional Thread.current.name = ... calls can raise NoMethodError on Rubies without…
• These unconditional Thread.current.name = ... calls can raise NoMethodError on Rubies without…
• As with the other servers, these thread-name assignments are unconditional and can raise…
• As with the other servers, these thread-name assignments are unconditional and can raise…
• As with the other servers, these thread-name assignments are unconditional and can raise…
• Draining @threads via threads << @threads.pop until @threads.empty? can miss threads that get…

_{Review effort: Lite}