[SPARK-56455][SQL][TESTS] Add test coverage for maxBroadcastTableSize config enforcement#55313
Open
pratham76 wants to merge 1 commit intoapache:masterfrom
Open
[SPARK-56455][SQL][TESTS] Add test coverage for maxBroadcastTableSize config enforcement#55313pratham76 wants to merge 1 commit intoapache:masterfrom
pratham76 wants to merge 1 commit intoapache:masterfrom
Conversation
Author
|
@sunchao @dongjoon-hyun Could you have a look? Thanks! |
sunchao
approved these changes
Apr 12, 2026
| val ex = intercept[SparkException] { | ||
| joinDF.collect() | ||
| } | ||
| assert(ex.getMessage.contains("Cannot broadcast")) |
Member
There was a problem hiding this comment.
nit: this check is probably to board: since we are testing against maxBroadcastTableSize, we can check the error message directly here or the error code _LEGACY_ERROR_TEMP_2249.
Author
There was a problem hiding this comment.
Thanks @sunchao, have used the approach of using error code to verify here.
HyukjinKwon
changed the title
pratham76
force-pushed
the
test-broadcast
branch
from
e4bf10f to
022c945
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, there is no validation for enforcement of
spark.sql.maxBroadcastTableSize.This change introduces unit tests that:
Why are the changes needed?
This helps prevent regressions and ensures consistent enforcement of broadcast size limits.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing Test Suites -- additional test cases added
Was this patch authored or co-authored using generative AI tooling?
No