Skip to content

[Feature] support jedis-5.x #11747

Closed
apache/skywalking-java
#803

Description

@luger1990

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

The current skywalking java agent(apache-skywalking-java-agent-9.1.0.tgz) dosen't support jedis 5.x

Use case

No response

Related issues

No response

Are you willing to submit a pull request to implement this on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct

Activity

  1. wu-sheng commented on Jan 10, 2024

    @wu-sheng
    Member

    We are open to new plugin contributions. If you want to submit a new one, welcome.
    But for issue tracker, unless you are going to submit one in short term, we wouldn't keep this one open.
    Too many kind of requests could be opened. It is hard to follow.

  2. added
    agentLanguage agent related.
    javaJava agent related
    on Jan 10, 2024
  3. luger1990 commented on Jan 10, 2024

    @luger1990
    Author

    We are open to new plugin contributions. If you want to submit a new one, welcome. But for issue tracker, unless you are going to submit one in short term, we wouldn't keep this one open. Too many kind of requests could be opened. It is hard to follow.

    Does your team have any time plan for release the new plugin? Thanks

  4. wu-sheng commented on Jan 10, 2024

    @wu-sheng
    Member

    What do you mean my team? In a community, there is nothing about my team. SkyWalking doesn't work in this way.

  5. luger1990 commented on Jan 10, 2024

    @luger1990
    Author

    What do you mean my team? In a community, there is nothing about my team. SkyWalking doesn't work in this way.

    I want to know when will support jedis-5.x, i will roll back to use jedis-4.x if it take a long time.

  6. wu-sheng commented on Jan 10, 2024

    @wu-sheng
    Member

    No one is working on that. That is only thing I can say. No timeline, maybe tomorrow submit a pull request, maybe 1-2 years. No one knows.

    Like I said, this is not how SkyWalking works. This is not a work for anyone, including me.

  7. added this to the Java - 9.7.0 milestone on Apr 9, 2026
  8. self-assigned this
    on Apr 9, 2026
  9. wu-sheng commented on Apr 9, 2026

    @wu-sheng
    Member

    Jedis 5.x support has been added in apache/skywalking-java#803.

    The Jedis 4.x plugin is fully API-compatible with Jedis 5.x — all intercepted classes (Connection, Pipeline, Transaction, ConnectionProvider) and methods are unchanged. The plugin was silently not activating on 5.x because the witness method Pipeline.persist(1 arg) moved from Pipeline to parent PipeliningBase in 5.x.

    Fix: changed the witness to Connection.executeCommand(1 arg) which exists in both 4.x and 5.x but not in 3.x.

    Locally verified: Jedis 5.2.0 passed all test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

agentLanguage agent related.featureNew featurejavaJava agent related

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions