Repository navigation
Run typed cluster tests with classic remoting in PR validation - #3745
Merged
pjfanning merged 3 commits intoNov 2, 2026
Merged
Conversation
pjfanning
changed the title
Motivation: BasicClusterConfigSpec broke under classic remoting (apache#3741) and was only caught by the nightly build, because PR validation does not run cluster-typed/test with Artery disabled. Modification: Add cluster-typed/test as a separate matrix entry in the Pekko Classic Remoting Tests job. Result: Classic remoting regressions in cluster-typed are caught on PRs. Tests: - Not run locally - CI workflow change; this PR's checks exercise it References: Refs apache#3741, Refs apache#3742
…idation Motivation: The nightly classic remoting job runs cluster-sharding-typed/test alongside cluster-typed/test; PR validation should match. Modification: Add cluster-sharding-typed/test to the cluster-typed matrix entry. Result: PR validation covers the same typed cluster modules as the nightly job. Tests: - Not run locally - CI workflow change; this PR's checks exercise it References: Refs apache#3741
pjfanning
force-pushed
the
ci/classic-remoting-cluster-typed
branch
from
November 2, 2026 12:55
d47d520 to
42e536a
Compare
Member
|
Thanks for this. |
Motivation: With classic remoting, BasicClusterConfigSpec "init cluster" was flaky. The first seed waits the default 5s seed-node-timeout before forming the cluster, and the other node retries InitJoin every 5s. A retry that lands just before the first seed forms the cluster pushes the join to ~10s, which races the 10s eventually timeout. Modification: Set pekko.cluster.seed-node-timeout = 1s in the per-port test config, which is not part of the docs snippet. Result: The two nodes form a cluster within a few seconds instead of up to ~10s. Tests: - Not run locally - CI runs cluster-typed tests with classic remoting References: Refs apache#3745
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
BasicClusterConfigSpecbroke under classic remoting (#3741) and was only caught by the nightly build, because PR validation does not runcluster-typed/testorcluster-sharding-typed/testwith-Dpekko.remote.artery.enabled=off.Modification
Add
cluster-typed/test cluster-sharding-typed/testas a separate matrix entry in thePekko Classic Remoting Testsjob (matching the nightly job's entry), so it runs in parallel with the existing entry rather than lengthening it.Result
Classic remoting regressions in the typed cluster modules are caught on PRs.
Tests
Pekko Classic Remoting Tests (cluster-typed/test cluster-sharding-typed/test)check exercises it.References
Refs #3741, Refs #3742