Skip to content

Fix classic remoting seed addresses in BasicClusterConfigSpec #3742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
He-Pin merged 1 commit into from
Nov 2, 2026
Merged

Fix classic remoting seed addresses in BasicClusterConfigSpec #3742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...er-typed/src/test/scala/docs/org/apache/pekko/cluster/typed/BasicClusterExampleSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,11 +132,15 @@ class BasicClusterConfigSpec extends AnyWordSpec with ScalaFutures with Eventual
val sys1Port = addresses.head.getPort
val sys2Port = addresses.last.getPort
sys1Port should not be sys2Port
val arteryEnabled =
configSystem1.withFallback(ConfigFactory.defaultReference()).getBoolean("pekko.remote.artery.enabled")
val protocol = if (arteryEnabled) "pekko" else "pekko.tcp"
def config(port: Int) = ConfigFactory.parseString(s"""
pekko.remote.classic.netty.tcp.hostname = "127.0.0.1"
pekko.remote.classic.netty.tcp.port = $port
pekko.remote.artery.canonical.port = $port
pekko.cluster.jmx.multi-mbeans-in-same-jvm = on
pekko.cluster.seed-nodes = [ "pekko://ClusterSystem@127.0.0.1:$sys1Port", "pekko://ClusterSystem@127.0.0.1:$sys2Port" ]
pekko.cluster.seed-nodes = [ "$protocol://ClusterSystem@127.0.0.1:$sys1Port", "$protocol://ClusterSystem@127.0.0.1:$sys2Port" ]
""")

val system1 =
Expand All @@ -149,6 +153,8 @@ class BasicClusterConfigSpec extends AnyWordSpec with ScalaFutures with Eventual
clusters.foreach { cluster =>
cluster.state.members.size shouldBe 2
cluster.state.members.unsorted.map(_.status) shouldBe Set(MemberStatus.Up)
cluster.state.members.unsorted.map(_.address.protocol) shouldBe Set(protocol)
cluster.state.members.unsorted.map(_.address.host) shouldBe Set(Some("127.0.0.1"))
cluster.state.members.unsorted.map(_.address.port.get) shouldBe Set(sys1Port, sys2Port)
}
}
Expand Down