Repository navigation
Conversation
Motivation: The list of IncludeTags/IncludeRegexEntityIds/IncludeEntityIds in grpc.md was introduced as "The exclude criteria can be a combination of". Modification: Say "include criteria" for the include list. Result: The filter docs describe the include criteria correctly. Tests: - Not run - docs only References: Refs akka/akka-projection#1018 (akka/akka-projection#1018) - source of the doc fix
pjfanning
force-pushed
the
port-akka-1018-docs-include-criteria
branch
from
October 27, 2026 08:38
e0bd92d to
2e013d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The list of
IncludeTags/IncludeRegexEntityIds/IncludeEntityIdsingrpc.mdwas introduced as "The exclude criteria can be a combination of".Modification
Say "include criteria" for the include list.
Result
The consumer filter docs describe the include criteria correctly.
Tests
References
Refs akka/akka-projection#1018 (akka/akka-projection#1018) - source of the doc fix (Akka Projection 1.5.0, now Apache licensed)