[VL] Fix shallow CreateNamedStruct detection in CollapseProjectExecTransformer#11953
Merged
acvictor merged 2 commits intoapache:mainfrom Apr 17, 2026
Merged
[VL] Fix shallow CreateNamedStruct detection in CollapseProjectExecTransformer#11953acvictor merged 2 commits intoapache:mainfrom
acvictor merged 2 commits intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI on x86 |
Contributor
|
@acvictor Thanks for the fix. Could you add a test case for that error case, if possible? |
|
Run Gluten Clickhouse CI on x86 |
acvictor
force-pushed
the
acvictor/collapsePattern
branch
from
7b0ddbf to
447340f
Compare
|
Run Gluten Clickhouse CI on x86 |
acvictor
force-pushed
the
acvictor/collapsePattern
branch
from
447340f to
40df8a7
Compare
|
Run Gluten Clickhouse CI on x86 |
acvictor
force-pushed
the
acvictor/collapsePattern
branch
from
40df8a7 to
15d54fc
Compare
|
Run Gluten Clickhouse CI on x86 |
acvictor
force-pushed
the
acvictor/collapsePattern
branch
from
15d54fc to
91a356d
Compare
|
Run Gluten Clickhouse CI on x86 |
acvictor
force-pushed
the
acvictor/collapsePattern
branch
from
91a356d to
4f567cf
Compare
|
Run Gluten Clickhouse CI on x86 |
acvictor
force-pushed
the
acvictor/collapsePattern
branch
from
4f567cf to
059cd45
Compare
|
Run Gluten Clickhouse CI on x86 |
jinchengchenghh
approved these changes
Apr 17, 2026
Contributor
jinchengchenghh
left a comment
jinchengchenghh
left a comment
There was a problem hiding this comment.
Thanks for your fix!
Contributor
Author
Added UTs for all Spark versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
containsNamedStructAliasinCollapseProjectExecTransformerguards against collapsing project nodes whenCreateNamedStructis present, since Velox generates a special obj output that breaks bind reference resolution after collapse. The existing pattern match only detectsCreateNamedStructas the direct child ofAliasand missesCreateNamedStructnested inside any wrapper expression likeIf,CaseWhenallowing unsafe collapse that causes Velox bind reference failures at runtime. This PR usesexpression.existsto walk the full subtree.How was this patch tested?
Existing UT
Was this patch authored or co-authored using generative AI tooling?
No