[fix](env) fix beut build#63691
Merged
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
/review |
Contributor
Author
|
run buildall |
BiteTheDDDDt
approved these changes
May 26, 2026
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 31748 ms |
Contributor
TPC-DS: Total hot run time: 172643 ms |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
approved these changes
May 27, 2026
Contributor
Author
|
/review |
Contributor
|
skip buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Automated review summary for PR #63691:
No blocking issues found.
Critical checkpoint conclusions:
- Goal/test proof: The PR removes a redundant
ColumnUInt8cast infunction_geo_st_geometries_invalid; the existing unit test continues to exercise invalid non-null geometry input and expected nullable output. - Scope/minimality: The change is minimal and focused, with no unrelated modifications.
- Concurrency/lifecycle: Not applicable; this is test-only code constructing local columns.
- Configuration/compatibility/persistence/protocol: Not applicable; no runtime config, storage format, RPC, or persistence changes.
- Parallel paths: The changed API call matches
ColumnNullable::get_null_map_column_ptr()returningColumnUInt8::MutablePtr; no other path needs an equivalent functional change. - Special conditions: The null-map insertion remains explicit and preserves the intended non-null invalid input row.
- Test coverage/results: Existing BE unit test coverage is directly preserved; I did not run the BE unit test in this review environment.
- Observability/performance/data correctness: Not applicable beyond confirming no behavior change in the test setup.
User focus: No additional user-provided review focus was present.
zhaorongsheng
pushed a commit
to zhaorongsheng/doris
that referenced
this pull request
Jun 4, 2026
### What problem does this PR solve? apache#63491 apache#63049 ``` ../src/core/assert_cast.h:54:19: error: static assertion failed due to requirement '!std::is_same_v<doris::ColumnVector<doris::TYPE_BOOLEAN> *, doris::ColumnVector<doris::TYPE_BOOLEAN> *>': assert_cast is redundant for the same type after removing cv/ref qualifiers 54 | static_assert(!std::is_same_v<AssertCastNormalizedType_t<To>, AssertCastNormalizedType_t<From>>, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../test/exprs/function/geo/functions_geo_test.cpp:375:5: note: in instantiation of function template specialization 'assert_cast<doris::ColumnVector<doris::TYPE_BOOLEAN> *, TypeCheckOnRelease::ENABLE, doris::ColumnVector<doris::TYPE_BOOLEAN> *>' requested here 375 | assert_cast<ColumnUInt8*>(nullable_input->get_null_map_column_ptr().get())->insert_value(0); | ^ 1 error generated. ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#63491
#63049
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)