Fix domain parsing for GPU & add Display controller in the supported PCI class by vishesh92 · Pull Request #12981 · apache/cloudstack

vishesh92 · 2026-04-08T08:47:01Z

Description

This PR fixes #12960 & #12957

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copilot

Pull request overview

This PR addresses CloudStack issue #12960 where GPU passthrough VM creation can fail on KVM due to incorrect parsing of PCI addresses (notably when the domain portion is present/expanded), leading to invalid libvirt PCI slot values.

Changes:

Update KVM GPU discovery script to consistently normalize/handle PCI addresses with and without an explicit domain and to key lookups using the domain-qualified form.
Update LibvirtGpuDef PCI XML generation to accept both bb:ss.f and dddd:bb:ss.f bus address formats.
Add unit tests covering full PCI addresses (domain 0, non-zero domain) and legacy short BDF behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
scripts/vm/hypervisor/kvm/gpudiscovery.sh	Normalizes PCI address handling (domain-aware) across sysfs access, cache keys, and VM usage mapping to avoid wrong BDF parsing.
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtGpuDef.java	Extends PCI address parsing to support `domain:bus:slot.func` input, preventing slot mis-parsing when a domain is present.
plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/LibvirtGpuDefTest.java	Adds regression/unit tests for full PCI addresses and backward compatibility for short BDF inputs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtGpuDef.java

plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/LibvirtGpuDefTest.java

codecov · 2026-04-08T08:56:02Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.60%. Comparing base (abdf926) to head (4e7a834).
⚠️ Report is 2 commits behind head on 4.22.

Additional details and impacted files

@@            Coverage Diff            @@
##               4.22   #12981   +/-   ##
=========================================
  Coverage     17.60%   17.60%           
- Complexity    15673    15680    +7     
=========================================
  Files          5918     5918           
  Lines        531681   531739   +58     
  Branches      65005    65016   +11     
=========================================
+ Hits          93589    93636   +47     
- Misses       427539   427545    +6     
- Partials      10553    10558    +5

Flag	Coverage Δ
uitests	`3.70% <ø> (ø)`
unittests	`18.68% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

this adds support for the amd instinct mi2xx accelorator crards in the discovery script.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

scripts/vm/hypervisor/kvm/gpudiscovery.sh

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtGpuDef.java

vishesh92 · 2026-04-08T10:13:05Z

@blueorangutan package

blueorangutan · 2026-04-08T10:14:05Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

scripts/vm/hypervisor/kvm/gpudiscovery.sh

blueorangutan · 2026-04-08T11:06:02Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17398

vishesh92 · 2026-04-08T11:40:36Z

@blueorangutan package

blueorangutan · 2026-04-08T11:42:04Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

scripts/vm/hypervisor/kvm/gpudiscovery.sh

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtGpuDef.java

sureshanaparti

clgtm

blueorangutan · 2026-04-08T12:33:53Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17399

vishesh92 · 2026-04-08T12:53:17Z

@blueorangutan test

blueorangutan · 2026-04-08T12:54:04Z

@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-04-09T04:49:03Z

[SF] Trillian test result (tid-15827)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 54183 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12981-t15827-kvm-ol8.zip
Smoke tests completed. 148 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_redundant_vpc_site2site_vpn	`Failure`	474.42	test_vpc_vpn.py

vishesh92 · 2026-04-09T06:13:42Z

Tested here: #12960 (comment)

DaanHoogland

clgtm

DaanHoogland · 2026-04-09T07:44:51Z

don’t think we can test more, ...

Fix domain parsing for GPU

7d7b664

boring-cyborg bot added the component:kvm label Apr 8, 2026

vishesh92 requested review from Copilot and sureshanaparti April 8, 2026 08:47

Copilot started reviewing on behalf of vishesh92 April 8, 2026 08:47 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtGpuDef.java Outdated Show resolved Hide resolved

plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/LibvirtGpuDefTest.java Outdated Show resolved Hide resolved

vishesh92 and others added 3 commits April 8, 2026 14:32

Address comments

78a5114

Add Display controller to GPU class check

8ead015

this adds support for the amd instinct mi2xx accelorator crards in the discovery script.

fixup

6fa2a88

vishesh92 mentioned this pull request Apr 8, 2026

Add Display controller to GPU class check #12959

Closed

14 tasks

vishesh92 changed the title ~~Fix domain parsing for GPU~~ Fix domain parsing for GPU & add Display controller in the supported PCI class Apr 8, 2026

vishesh92 requested a review from Copilot April 8, 2026 09:13

Copilot started reviewing on behalf of vishesh92 April 8, 2026 09:14 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

scripts/vm/hypervisor/kvm/gpudiscovery.sh Show resolved Hide resolved

scripts/vm/hypervisor/kvm/gpudiscovery.sh Outdated Show resolved Hide resolved

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtGpuDef.java Show resolved Hide resolved

DaanHoogland added this to the 4.22.1 milestone Apr 8, 2026

This was linked to issues Apr 8, 2026

GPU Discovery not detecting AMD Mi2xx GPUs #12957

Open

CloudStack 4.22 – GPU passthrough VM creation fails due to invalid PCI slot mapping #12960

Open

Address comments

8d09790

vishesh92 requested a review from Copilot April 8, 2026 10:12

Copilot AI reviewed Apr 8, 2026

View reviewed changes

scripts/vm/hypervisor/kvm/gpudiscovery.sh Show resolved Hide resolved

scripts/vm/hypervisor/kvm/gpudiscovery.sh Show resolved Hide resolved

scripts/vm/hypervisor/kvm/gpudiscovery.sh Show resolved Hide resolved

Copilot started reviewing on behalf of vishesh92 April 8, 2026 10:30 View session

Address comments

4e7a834

vishesh92 requested a review from Copilot April 8, 2026 11:40

Copilot started reviewing on behalf of vishesh92 April 8, 2026 11:47 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

sureshanaparti approved these changes Apr 8, 2026

View reviewed changes

sureshanaparti added this to Apache CloudStack 4.22.1 Apr 8, 2026

github-project-automation bot moved this to Todo in Apache CloudStack 4.22.1 Apr 8, 2026

sureshanaparti moved this from Todo to In Progress in Apache CloudStack 4.22.1 Apr 8, 2026

sureshanaparti added status:needs-testing ready-for-testing labels Apr 8, 2026

vishesh92 added the component:gpu label Apr 9, 2026

DaanHoogland approved these changes Apr 9, 2026

View reviewed changes

DaanHoogland added status:ready-for-merge and removed status:needs-testing ready-for-testing labels Apr 9, 2026

Conversation

vishesh92 commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vishesh92 commented Apr 8, 2026

Uh oh!

blueorangutan commented Apr 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

blueorangutan commented Apr 8, 2026

Uh oh!

vishesh92 commented Apr 8, 2026

Uh oh!

blueorangutan commented Apr 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Apr 8, 2026

Uh oh!

vishesh92 commented Apr 8, 2026

Uh oh!

blueorangutan commented Apr 8, 2026

Uh oh!

blueorangutan commented Apr 9, 2026

Uh oh!

vishesh92 commented Apr 9, 2026

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

vishesh92 commented Apr 8, 2026 •

edited

Loading

codecov bot commented Apr 8, 2026 •

edited

Loading