[CELEBORN-2016] Fix the worker decommission and graceful shutdown condition#3727
Open
s0nskar wants to merge 1 commit into
Open
[CELEBORN-2016] Fix the worker decommission and graceful shutdown condition#3727s0nskar wants to merge 1 commit into
s0nskar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In current code, we set the shutdown hook for
timeouttime and condition tries to checktimeSpent < timeoutwhen this condition is will become true, shutdown hook timer is already passed and VM will exit without executing the code below this point.New condition will be
timeSpent + interval < timeout, so we will get (0, interval] time to execute the below code.Why are the changes needed?
We current shutdown logic we have seen worker getting shutdown abruptly with timeout exception without completely executing the shutdown hook because of which Celeborn is unable to print unreleased partition location and unreleased shuffle on decommission and graceful shutdown.
Does this PR resolve a correctness bug?
Does this PR introduce any user-facing change?
How was this patch tested?
NA