[CELEBORN-2166] Mark shuffle data lost and fast fail if allocated worker is lost#3726
Open
s0nskar wants to merge 3 commits into
Open
[CELEBORN-2166] Mark shuffle data lost and fast fail if allocated worker is lost#3726s0nskar wants to merge 3 commits into
s0nskar wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enhancing the logic of #3496
Why are the changes needed?
#3496 only handles the reduce side flow i.e GetReducerFileGroup request will fail if the shuffle data is mark lost.
In this PR, we are making use of the
WorkerStatusListenerto immediately detect the lost workers, mark the data lost of the stage and immediately issue stage end for that stage. This will also allow write stage to fast-fail during revives and commit request, otherwise write stage will run as usual and then reduce will fail at startup. This will lead to lot of resource and time wastage.Does this PR resolve a correctness bug?
Does this PR introduce any user-facing change?
How was this patch tested?