fix(bthread/context): Add .previous after GNU-stack note for aarch64#3266
Open
condy0919 wants to merge 1 commit intoapache:masterfrom
Open
fix(bthread/context): Add .previous after GNU-stack note for aarch64#3266condy0919 wants to merge 1 commit intoapache:masterfrom
condy0919 wants to merge 1 commit intoapache:masterfrom
Conversation
Add missing .previous directive after each .note.GNU-stack section in ARM inline assembly blocks. This ensures proper section switching and prevents potential assembler errors when building with asan. See apache#1186
condy0919
changed the title
There was a problem hiding this comment.
Pull request overview
This PR fixes ARM inline-assembly section switching in bthread/context.cpp by adding a missing .previous directive after emitting the .note.GNU-stack section, preventing the assembler from remaining in the discarded .note.GNU-stack section (which can surface as link/ASAN build errors).
Changes:
- Add
.previousafter.section .note.GNU-stack,"",%progbitsin the Linux ARM32bthread_jump_fcontextandbthread_make_fcontextasm blocks. - Add
.previousafter.section .note.GNU-stack,"",%progbitsin the Linux ARM64bthread_jump_fcontextandbthread_make_fcontextasm blocks.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing .previous directive after each .note.GNU-stack section in ARM inline assembly blocks. This ensures proper section switching and prevents potential assembler errors when building with asan.
What problem does this PR solve?
Issue Number: resolve #1186
Problem Summary:
When build brpc with asan enabled, gcc complains something similar with the following line