Remove light-sql-experimental feature from rrow-flight#10335
Open
Harshalj2108 wants to merge 2 commits into
Open
Remove light-sql-experimental feature from rrow-flight#10335Harshalj2108 wants to merge 2 commits into
Harshalj2108 wants to merge 2 commits into
Conversation
github-actions
Bot
added
arrow
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the long-deprecated flight-sql-experimental Cargo feature alias from the arrow-flight crate now that the project is performing a major release and can drop the backwards-compatibility shim.
Changes:
- Removed the
flight-sql-experimentalfeature definition (and its TODO note) fromarrow-flight/Cargo.toml, leavingflight-sqlas the sole supported feature flag.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Jefffrey
added
the
next-major-release
Contributor
|
thanks for this PR, though we'll need to wait a bit until the next major release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10276.
Rationale for this change
The
flight-sql-experimentalfeature inarrow-flightwas previously renamed toflight-sqlin #7498 and #7546. Theflight-sql-experimentalfeature was kept as an alias for backwards compatibility, with a TODO note indicating it should be removed in the next release. Since this requires a major release, it is now time to remove it completely.What changes are included in this PR?
flight-sql-experimentalfeature definition fromarrow-flight/Cargo.toml.Are these changes tested?
Yes, existing CI tests will cover this (since it just removes an alias feature flag).
Are there any user-facing changes?
Yes, any users still depending on the
flight-sql-experimentalfeature flag will now need to update theirCargo.tomlto useflight-sqlinstead.