fix(arrow/array): validate map builder entry lengths#957
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
MapBuildercurrently sizes its child struct from the key builder without checking the item builder. Unequal key and item counts can therefore create malformed map data or defer the failure until later array access.What changes are included in this PR?
arrow.ErrInvalid, consistent with the existing builder API.Are these changes tested?
Yes. Tests cover extra keys, extra items, an oversized child struct, and a final offset that exceeds the available entries. The array subtree tests, focused race tests, 10 repeated package runs, and linux/amd64 compilation pass.
Are there any user-facing changes?
Malformed map builder state now fails immediately with a descriptive invalid-data panic instead of constructing an inconsistent array or panicking during later access. Valid builder usage is unchanged.