docs: reorganize docs to highlight tools and drivers#4525
Conversation
| Installing Drivers | ||
| ================== | ||
|
|
||
| You'll need to install an ADBC driver for the database you want to connect to. The easiest way is using `dbc <https://docs.columnar.tech/dbc>`_: |
There was a problem hiding this comment.
We should make it clear that this is a third party, and perhaps mention that drivers developed by us are still distributed on PyPI, with other drivers distributed by the third party
| Installing Drivers | ||
| ================== | ||
|
|
||
| You'll need to install an ADBC driver for the database you want to connect to. The easiest way is using `dbc <https://docs.columnar.tech/dbc>`_: |
There was a problem hiding this comment.
Since this is repeated a lot, is there a way we can put this in a separate file and include it wherever we use it?
There was a problem hiding this comment.
I said this elsewhere but now all quickstarts should be following this kind of pattern,
Installing Drivers
------------------
See Installing Drivers for instructions on installing ADBC drivers for the
database you want to connect to. For the example below, you could install dbc
and run dbc install postgresql.
| ========== | ||
|
|
||
| Here we'll briefly tour basic features of ADBC with the PostgreSQL driver for Java. | ||
| Here we'll briefly tour basic features of ADBC with Java using the PostgreSQL driver. |
There was a problem hiding this comment.
The current example does appear to use the JDBC adapter; maybe it should be switched to use the JNI adapter?
Co-authored-by: David Li <li.davidm96@gmail.com>
Co-authored-by: David Li <li.davidm96@gmail.com>
Co-authored-by: David Li <li.davidm96@gmail.com>
|
|
||
| ---- | ||
|
|
||
| dplyr |
| /// # Install dbc | ||
| /// curl -fsSL https://dbc.sh | sh |
There was a problem hiding this comment.
Hrm... I know the recipe needs this. Could we avoid telling users how to install dbc by moving this into cpp_recipe.sh and just showing running dbc install sqlite?
There was a problem hiding this comment.
Also, this is the incorrect install command. Should be:
curl -LsSf https://dbc.columnar.tech/install.sh | shBut it's probably better to just say:
See the `dbc documentation <https://docs.columnar.tech/dbc>`_ for how to install dbc.There was a problem hiding this comment.
Yep. This should be gone now. Anywhere we need to tell users to install a driver with dbc should use this language:
Installing Drivers
------------------
See :ref:`driver-table-install` for instructions on installing ADBC drivers for
the database you want to connect to. For the example below, you could install
`dbc <https://docs.columnar.tech/dbc>`__ and run ``dbc install postgresql``.and we can easily tweak it everywhere if we want something different.
There was a problem hiding this comment.
Oh, sorry, I can revert my commit. But I'm confused; how is it gone if I'm still seeing it here?
There was a problem hiding this comment.
Oh, I think your fixes missed the C++ one.
Maybe it's better to keep it my way just for the C++ one, since --level user is needed to avoid installing the driver in the conda environment.
|
Updated OP, TODO copied here for posterity, TODO:
|
| The easiest way to get it is with `dbc <https://docs.columnar.tech/dbc/>`__, | ||
| which installs prebuilt driver binaries from Columnar's `ADBC driver registry | ||
| <https://dbc-cdn.columnar.tech>`__: |
There was a problem hiding this comment.
Since this is a JavaScript example and it already requires npm, any objections to suggesting this here?
npm install -g @columnar-tech/dbc| See :ref:`driver-table-install` for instructions on installing ADBC drivers for | ||
| the database you want to connect to. For the example below, you could install | ||
| `dbc <https://docs.columnar.tech/dbc>`__ and run ``dbc install sqlite``. |
There was a problem hiding this comment.
Since this is a Python example and it already requires pip, any objections to suggesting this here?
pipx install dbc
This is a major reorganization and rethinking of the ADBC docs to catch them up with what's happening across the ADBC ecosystem.
The key changes are:
Closes #4233