IVY-1653: makepom: write overrides to Maven dependencyManagement section

[eric-milles]

Inspect the DependencyDescriptorMediator objects of ModuleDescriptor to represent overrides in Maven's dependencyManagement element.

https://issues.apache.org/jira/browse/IVY-1653

[maartenc]

I'm wondering what happens if you specify the organisation in the override, like in the example in the JIRA.
Will that give issues with the generated pom file? Will Maven be able to handle that?

[eric-milles]

This test case does just that:

ant-ivy/test/java/org/apache/ivy/core/module/descriptor/IvyMakePomTest.java

Line 157 in 29d68b0

" <groupId>org.aspectj</groupId>",

[maartenc]

Sure, but how does Maven handle the '*' artifactId? Does that work?

<dependency>
  <groupId>org.aspectj</groupId>
  <artifactId>*</artifactId>
  <version>1.9.24</version>
</dependency>

[eric-milles]

I'd have to try that with maven. Is there a concern that lots of top-level overrides are in use? Could this get taken as-is and if we find a compatibility problem, work it as a new issue?

[maartenc]

If maven gives errors on these wildcards, perhaps we could only add it to the dependencymanagement if the Ivy-override is fully specified (read: both groupId and artifactId have a non-wildcard value) ?
If maven doesn't complain about this wildcard, than we can just generate it like this PR does.

We should try to avoid generating pom.xml files that cannot be handled by Maven.

[eric-milles]

[ERROR] 'dependencyManagement.dependencies.dependency.artifactId' for org.eclipse.tycho:*:jar with value '*' does not match a valid id pattern.

[eric-milles]

I fixed the tests to write proper artifactId elements.

[maartenc]

Perhaps also return here if none of the rules are an instance of non-wildcard OverrideDependencyDescriptorMediator.
This way, we avoid an empty <dependencyManagement>/<dependencies>-construct if container was true.

[eric-milles]

Sure -- I tried to keep it simple instead of building up a filtered collection.

[maartenc]

Could you also add a test case for updating a template pom.xml that already has a dependencyManagement section, and we have an ivy.xml with an override element. (just to verify that an existing dependencyManagent gets updated correctly).

[maartenc]

I've added some comments, could you have a look?

[eric-milles]

I will get to your feedback on this one. Now that <override org="abc" rev="123" /> doesn't work, this drops in usefulness for me.

[eric-milles]

Could you review my PRs from oldest to newest?

[bodewig]

I will get to your feedback on this one. Now that <override org="abc" rev="123" /> doesn't work, this drops in usefulness for me.

I'm not deeply involved with Ivy so please bear with my ignorance.

Which effect do you expect a rule without a module attribute to have on a generated POM? Have Ivy find all transitive dependencies of explicit dependencies and add something to the POM replacing the * with all modules/artifacts found?

[eric-milles]

This is still in draft form since there are some compat issues raised that are not easily solved. You can ignore this until it is marked ready for review.