refactor(xiaomi-token-plan): extends xiaomi base provider for xiaomi token plans#1717
Merged
rekram1-node merged 1 commit intoMay 7, 2026
Merged
Conversation
Collaborator
|
hm that symlinking is a little odd |
juls0730
force-pushed
the
refactor/mimo-extends/token-plan
branch
from
5eaad85 to
ce391f0
Compare
juls0730
force-pushed
the
refactor/mimo-extends/token-plan
branch
from
ce391f0 to
1353f96
Compare
Contributor
Author
|
I understand. I have modified my changes so that the chinese token plan models now extend the base provider and in europe and singapore individual model files are instead all symlinks like v2 omni pro and tts I believe were instead of the whole folder. I also rounded v2 tts limits to powers of 2 jsyk LMK if you think my changes are good |
juls0730
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors all token plans excluding the chinese token plan to have the models folder be a symlink to reduce duplication since all three are identical. This is a bit more of an experimental PR and idk how open you are to accepting a change like this, but LMK. Sort of breakout commit of #1631