Repository navigation
Rename Backup/ → OriginalSource/ (descriptive name for the historical-reference folder) - #2
Merged
Merged
Conversation
Phase 8: rename the historical-reference folder from Backup/ to OriginalSource/ so the folder name describes what it actually contains (the original .NET Framework 1.0 WinForms source code, preserved verbatim for reference). The rename touches every reference across the repo: - OriginalSource/ (renamed from Backup/ via git mv; history follows) - AGENTS.md (5 references): the 'no using legacy types' rule, the anti-pattern table, the repo-layout section. - README.md (1 reference): the 'legacy code preserved' link. - docs/plan.md (2 references): master plan goal + Phase 6 summary. - docs/decisions/0004-solid-and-patterns.md (1 reference): the legacy-file citation in the SOLID contract. - docs/decisions/0006-coverage-tooling.md (1 reference): the coverlet runsettings filter description. - docs/phases/phase-1-blazor-host.md (1 reference): the inventory of files kept as historical reference. - docs/phases/phase-2-domain.md (3 references): provenance comments for Weight, ChickenMeal, TurkeyMeal. - docs/phases/phase-3-application-and-config.md (1 reference): the bug-fix citation. - docs/phases/phase-6-cleanup.md (5 references): scope, decisions, and anti-patterns. - docs/phases/phase-7-ci.md (2 references): the coverlet exclude rule and the namespace explanation. - Domain/Meals/ChickenMeal.cs (1 reference): the /// provenance comment. - Domain/Meals/TurkeyMeal.cs (1 reference): the /// provenance comment. - CookingTime.csproj (1 reference): the Enable*Default*Items workaround comment. - coverlet.runsettings.xml (2 references): the filter rules + comment. - scripts/check-coverage.py (1 reference): the PRODUCTION_FOLDERS comment. OriginalSource/ contents are kept verbatim. The folder is now named accurately: it is the original source code, untouched, for reading. Tests: 95 unit + 9 component + 8 integration + 6 new = 118 facts. Build: 0 warnings, 0 errors. UnitTests line coverage on production code: 80.00% (gate at 75%).
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the historical-reference folder from
Backup/toOriginalSource/so the folder name describes what it actually contains: the original .NET Framework 1.0 WinForms source code, preserved verbatim for reference, never built, never referenced by new code.This is a pure-rename PR. No production logic, no test logic, no docs content change — just folder rename + 27 reference updates.
phase/8-rename-original-source→upgrading-to-net-10(this branch)main5ca5ecc—checkpoint(phase-8): rename Backup/ to OriginalSource/v0.8-rename-original-sourceWhy
Backup/was a generic name that didn't tell a new reader what the folder was. The folder holds the original WinForms source code (verbatim, from before the .NET 10 upgrade), kept for historical reference perAGENTS.md. A new contributor opening the folder would findComCookingTime.cs,frmCookingTime.cs, etc. — i.e., the original source of the project.OriginalSource/makes that explicit at a glance. It's the vocabulary Microsoft's .NET Upgrade Assistant uses for the same idea.What changes
Backup/*→OriginalSource/*(git recorded the renames asR, sogit log --followandgit blamestill work).AGENTS.md— 5 references: the "nousinglegacy types" rule, the anti-pattern table, the repo-layout section.README.md— 1 reference: the "legacy code preserved" link.CookingTime.csproj— 1 reference: the<EnableDefault*Items>workaround comment.coverlet.runsettings.xml— 2 references: the filter rules + the namespace explanation comment.scripts/check-coverage.py— 1 reference: thePRODUCTION_FOLDERScomment.docs/plan.md— 2 references: master plan goal + Phase 6 summary.docs/decisions/0004-solid-and-patterns.md— 1 reference: the legacy-file citation in the SOLID contract.docs/decisions/0006-coverage-tooling.md— 1 reference: the coverlet runsettings filter description.docs/phases/phase-1-blazor-host.md— 1 reference: the inventory of files kept as historical reference.docs/phases/phase-2-domain.md— 3 references: provenance comments forWeight,ChickenMeal,TurkeyMeal.docs/phases/phase-3-application-and-config.md— 1 reference: the bug-fix citation.docs/phases/phase-6-cleanup.md— 5 references: scope, decisions, anti-patterns.docs/phases/phase-7-ci.md— 2 references: the coverlet exclude rule + the namespace explanation.Domain/Meals/ChickenMeal.cs— 1 reference: the///provenance comment.Domain/Meals/TurkeyMeal.cs— 1 reference: the///provenance comment.The two
///comments inChickenMeal.csandTurkeyMeal.csdocument where the domain tables came from. They stay as provenance, not dependencies — the new code doesn't import anything fromOriginalSource/.Diff summary
Of those 28:
Backup/X→OriginalSource/X) — 100% similarity.Out of scope
OriginalSource/contents are not changed. Every original WinForms file (.cs,.resx,.csproj,.sln,.suo,.ico) is preserved verbatim. Only the folder name changed.CookingTime.csprojcomment was updated, but the<EnableDefault*Items>workarounds are still required —OriginalSource/*.resxstill has non-string resources that would be auto-included without them.[OriginalSource.*]replaces[Backup.*]; same behavior.Validation
dotnet build -c Release— 0 warnings, 0 errors across all 4 projects.dotnet test -c Release --settings coverlet.runsettings.xml— 118 facts, 0 failed, 0 skipped.python3 scripts/check-coverage.py ... --threshold 75— exits 0 (UnitTests at 80.00% lines).git grep -n 'Backup/' -- ':!OriginalSource'— no matches outsideOriginalSource/and the meta-reference inCookingTime.csproj("renamed from Backup/ in Phase 8").How to verify locally
Checklist
phase/8-rename-original-sourceupgrading-to-net-10(the v0.7-ci tip)checkpoint(phase-8): rename Backup/ to OriginalSource/v0.8-rename-original-source