Repository navigation
feat: decide whether to use fallback stores based on record count - #1131
Draft
danielgafni wants to merge 2 commits into
Draft
danielgafni wants to merge 2 commits into
danielgafni wants to merge 2 commits into
Conversation
Collaborator
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
danielgafni
force-pushed
the
03-30-refactor_rename_and_move__collect_to_arrow_to_metaxy._utils.collect_to_arrow_
branch
from
March 30, 2026 18:45
ccea5c8 to
d202fa9
Compare
danielgafni
force-pushed
the
03-30-feat_decide_whether_to_use_fallback_stores_based_on_record_count
branch
from
March 30, 2026 18:45
82b97d1 to
66fa007
Compare
danielgafni
marked this pull request as ready for review
March 30, 2026 18:54
graphite-app
Bot
changed the base branch from
03-30-refactor_rename_and_move__collect_to_arrow_to_metaxy._utils.collect_to_arrow_
to
graphite-base/1131
March 30, 2026 18:57
graphite-app
Bot
force-pushed
the
graphite-base/1131
branch
from
March 30, 2026 19:06
d202fa9 to
d5e3fee
Compare
graphite-app
Bot
force-pushed
the
03-30-feat_decide_whether_to_use_fallback_stores_based_on_record_count
branch
from
March 30, 2026 19:06
66fa007 to
2f52df0
Compare
graphite-app
Bot
force-pushed
the
03-30-feat_decide_whether_to_use_fallback_stores_based_on_record_count
branch
from
March 30, 2026 19:06
2f52df0 to
f0fadc5
Compare
Collaborator
Author
|
It looks like we should only treat special, system filters this way:
|
danielgafni
marked this pull request as draft
March 30, 2026 19:25
danielgafni
force-pushed
the
03-30-feat_decide_whether_to_use_fallback_stores_based_on_record_count
branch
from
March 30, 2026 19:31
f0fadc5 to
2315403
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changelog
Test Plan