Repository navigation
Retire the staged rocm-doctor draft - #260
Merged
Merged
Conversation
`rocm-doctor` now ships from `ROCm/rocm-cli` via federation, so the draft under `staging/` is superseded. The two copies have already diverged, and nothing reconciles them: the vendored folder is rewritten by the nightly importer while the staged one stays frozen. Remove the staged copy and point the README row at the vendored skill, with the source repo in place of `_planned_`. The platform list follows the shipped skill card, which covers WSL2 as well as Linux and Windows. Signed-off-by: John Lybeck <john.lybeck@amd.com>
danielholanda
approved these changes
Oct 9, 2026
danielholanda
marked this pull request as ready for review
October 9, 2026 12:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #259. Draft until that merges, since the README link and the skill itself only exist under
skills/once it does.staging/rocm-doctor/, superseded by the federated copy fromROCm/rocm-cliskills/rocm-doctor/SKILL.mdand replace_planned_with the source repoThe two copies have already diverged (
SKILL.md180 vs 208 lines,reference.md91 vs 172). Nothing reconciles them: the nightly importer rewrites the vendored folder while the staged one stays frozen, so leaving it in place means a stale draft that the README still points at.Happy to fold this into #259 instead if you'd rather it landed as one change.
./.github/scripts/check.shpasses, 0 errors, 181 internal references resolve.