Skip to content

fix: apply profile theme before window creation - #9

Merged
purpleempress merged 1 commit into
mainfrom
fix/profile-theme-lifecycle
Aug 16, 2026
Merged

purpleempress merged 1 commit into
mainfrom
fix/profile-theme-lifecycle

Conversation

@purpleempress

Copy link
Copy Markdown
Member

Summary

  • apply the edit-profile dynamic theme during onPreCreate, before AppCompat creates the window
  • prevent the mixed light-window/dark-content profile screen visible in the released v8.23.2 build
  • add a Robolectric regression proving the pre-create hook selects the dynamic theme
  • export the fix as patch 22 and renumber the canonical patch subjects

Verification

  • focused Robolectric regression passes
  • :Signal-Android:compileWebsiteProdReleaseKotlin passes
  • forced patch-series materialisation succeeds
  • materialised focused regression and release Kotlin compile pass
  • exporter suite passes (39 tests)
  • git diff --check passes
  • commits are signed and DCO signed off

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be4d6b1900

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread patches/0022-fix-apply-profile-theme-before-window-creation.patch
@purpleempress
purpleempress force-pushed the fix/profile-theme-lifecycle branch from be4d6b1 to ce84e28 Compare August 16, 2026 14:05
Signed-off-by: amber <amber@flourish.ch>
@purpleempress
purpleempress force-pushed the fix/profile-theme-lifecycle branch from ce84e28 to 879253d Compare August 16, 2026 14:15
@purpleempress
purpleempress merged commit a5053a2 into main Aug 16, 2026
1 check passed
@purpleempress
purpleempress deleted the fix/profile-theme-lifecycle branch August 16, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant