Repository navigation
fix: restore Signal v8.31.1 patch compatibility - #34
Conversation
Preserve Signal upstream lifecycle and shared link-preview actions while retaining Vesper dynamic colours and the hidden payments UI. Re-export source-derived patches with original provenance and cover both the published pin and candidate in artifact-only PR CI. Signed-off-by: amber <amber@flourish.ch>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 156851bd8e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| python3 tools/test_conversation_patch.py -v | ||
| python3 tools/test_signal_830_patch.py -v | ||
| python3 tools/test_signal_831_patch.py -v | ||
| python3 tools/test_transform_source_colors.py -v |
There was a problem hiding this comment.
Run the source-color tests through pytest
This command silently runs zero tests because test_transform_source_colors.py only declares pytest functions and has no executable entry point; its -v argument is consequently ignored. Directly invoking the command exits successfully with no output, whereas pytest -q tools/test_transform_source_colors.py runs 10 tests. The same ineffective command was added to pull-request.yml, so neither CI workflow exercises this transform regression suite; invoke it through pytest or add a real test runner.
Useful? React with 👍 / 👎.
Summary
pinnedandv8.31.1, preserving its pinned check name, same-repository guard, read-only permissions and independent matrix legs.upstream.pinat v8.30.2. Candidate adoption/publication is a separate operation after this repair lands.Verification
:Signal-Android:assembleWebsiteProdReleaseon v8.30.2 and v8.31.1; unsigned universal APK package/version and ZIP integrity verified.25d4b4a69dde3a11fa42f5f7f76b2a282d3f0955; v8.31.1db34a2f18ff3b599e2925667c513ac18644c6f9e.Signal pinned release(job 114255347611) andSignal v8.31.1(job 114255347785). Both unsigned universal APK artifacts uploaded. All check annotations reviewed: one existing upstreamPushDecryptMessageJobEnvelopeMigration.java:14missing-@Deprecatedwarning per leg, no errors.Scope and release sequencing
Only eight wrapper files change; no generated worktree, signing material or pin advancement is included. Most patch 0001 churn is exported context changing to two lines; semantic changes are import anchors and moving receiver-specific link-preview colour handling into a narrowly matched source transform. Patch 0011 retains upstream biometric support but not the payment preference or authentication invocation.
Merging triggers the normal signed pinned build. Wait for that production run to finish before dispatching the v8.31.1 adoption build with
advance_pin=true: the two concurrency groups share the same live manifest target. No production dispatch or publication is part of this PR validation.