Skip to content

fix: restore Signal v8.29.2 Android CI - #29

Merged
purpleempress merged 1 commit into
mainfrom
fix/ci-signal-20260930
Sep 30, 2026
Merged

purpleempress merged 1 commit into
mainfrom
fix/ci-signal-20260930

Conversation

@purpleempress

Copy link
Copy Markdown
Member

Summary

  • Preserve the Material You import patch across Signal v8.29.1 and v8.29.2 without dropping upstream ComposeColor support.
  • Reset shared Vesper configuration after tests and add a deterministic lifecycle regression.
  • Validate pinned v8.29.1 and candidate v8.29.2 in the existing PR build matrix.

Validation

  • Both source versions materialise successfully with all 28 patches.
  • Local Python regression checks and candidate selected Gradle tests pass.
  • Full native release builds are required from both PR jobs before merge.
  • Published upstream pin is unchanged.

Re-anchor the source-generated MaterialR import hunk after the shared CoreUiR alias, retaining upstream ComposeColor and every existing feature change. Check both upstream import layouts and materialised theme hooks, and validate the pinned release plus v8.29.2 in the artifact-only PR matrix.

Full local Gradle validation also exposed process-wide VesperConfig test state leaking into the upstream static-value checks. Reset it after every test and exercise the actual JUnit lifecycle to prevent order-dependent failures. Keep the published upstream pin unchanged.

Signed-off-by: amber <amber@flourish.ch>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-30T06:20:41.706966Z bd05b23 PR opened
🔒 Security Review ✅ Completed 2026-09-30T06:21:06.930742Z bd05b23 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bd05b23808

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tools/test_conversation_patch.py
@purpleempress
purpleempress merged commit 810266f into main Sep 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant