Skip to content

fix: restore Android CI for Signal v8.29.0 - #27

Merged
purpleempress merged 1 commit into
mainfrom
fix/ci-signal-8.29
Sep 24, 2026
Merged

purpleempress merged 1 commit into
mainfrom
fix/ci-signal-8.29

Conversation

@purpleempress

@purpleempress purpleempress commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Rebase four patches across Signal v8.29.0 import and RemoteConfig changes without dropping feature hunks.
  • Preserve new upstream internal-override resolution; apply Vesper account overrides after resolution for delegated reads only.
  • Keep the known-good v8.28.3 pin; validate pinned and candidate v8.29.0 in the existing artifact-only PR matrix.
  • Extend both build paths with RemoteConfig and VesperConfig tests; retain settings, lifecycle, wrapper validation, and full release assembly.

Validation

  • Reproduced scheduled failure locally; discovered and repaired three further patch conflicts.
  • Fresh materialisation succeeds on both versions, all 27 patches preserve author/date/message provenance.
  • Candidate exported tree equals the rebased source tree: 88a57ec30db681a5d345d5e610cff7af267a2c18.
  • 41 exporter tests, 10 transform tests, and six materialised contract tests per version pass. Full Android CI succeeds for both versions in run 35991389366; downloaded APKs verify as systems.amber.vesper versions 8.28.3 and 8.29.0.

Publication

PR CI only uploads unsigned artifacts. No merge or publication requested by this PR itself; build dispatch signs and publishes live updates, so it is not used as a validation shortcut.

Preserve upstream internal override resolution and Vesper account policy. Retain v8.28.3 compatibility and validate both releases with configuration, settings, lifecycle tests and full APK assembly.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T11:12:54.532705Z 7cb3bf5 PR opened
🔒 Security Review ✅ Completed 2026-09-24T11:13:09.180289Z 7cb3bf5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7cb3bf5391

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

val transformer: (Any?) -> T
) {
operator fun getValue(thisRef: Any?, property: KProperty<*>): T {
+ // Keep the upstream raw-value resolver, then apply Vesper's account policy.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the required DCO sign-off

This commit has no Signed-off-by: trailer, although CONTRIBUTING.md requires every contribution commit to include a Developer Certificate of Origin sign-off. Add the author’s sign-off before merging.

AGENTS.md reference: AGENTS.md:L45-L45

Useful? React with 👍 / 👎.

@purpleempress

Copy link
Copy Markdown
Member Author

Full Android CI is green on 7cb3bf5: https://github.com/ambr-s/vesper-android/actions/runs/35991389366

  • Signal v8.29.0 job 107606062794: success (10m52s).
  • Pinned Signal v8.28.3 job 107606063006: success (7m54s).
  • Both ran the unchanged settings/lifecycle tests plus expanded RemoteConfig and VesperConfig tests, wrapper validation, full release assembly, and unsigned universal APK upload.
  • Downloaded both artifacts, verified ZIP integrity and all four ABIs. SHA-256: candidate 4223520791e8bd587b545a28b0d9d888cc0daea096fb8312b115ebefaa62f92a; pinned c07278f809474a53f633224fb8865464eeb45e3ee02722ab7489824d19ec1e8e.
  • Local checks: 41 exporter tests, 10 transform tests, six source contracts on each version, actionlint, bash syntax, clean generated trees, byte-identical candidate tree after re-export/rematerialisation.
  • Annotation audit: only pre-existing upstream Java missing-@deprecated warning in PushDecryptMessageJobEnvelopeMigration.java; no action-runtime warnings.

No merge, pin advance, signing, tag creation or live publication has been performed. Existing scheduled adoption on main will remain unfixed until this repair is merged. Publishing dispatch is deliberately not used as a test shortcut.

@purpleempress
purpleempress merged commit b142fb8 into main Sep 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant