Repository navigation
fix: restore Signal v8.28.2 materialisation and validate both releases - #25
Conversation
Generate the theme patch from the candidate source while anchoring the color resolver replacement after SignalTheme. This preserves upstream's new compatible window insets and keeps the patch applicable to the published v8.28.0 pin. Validate both releases in artifact-only PR CI; do not advance the publication pin. Signed-off-by: amber <amber@flourish.ch>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Verification complete for a5ba176. Passing run: https://github.com/ambr-s/vesper-android/actions/runs/35401391110 Both Signal pinned release (v8.28.0) and Signal v8.28.2 completed successfully, including fresh materialisation, 41 exporter tests, 5 theme source contracts, VesperSettingsValuesTest, EditProfileActivityThemeLifecycleTest, full assembleWebsiteProdRelease, and unsigned universal APK uploads. Downloaded the candidate artifact and verified ZIP integrity, package systems.amber.vesper, version 8.28.2 (175301), and all four ABIs. APK SHA-256: Each check has one compiler warning: |
Root cause
Signal v8.28.2 inserted the systemBarsCompat import into the context of the Material You patch. Direct git am therefore rejected MainActivity.kt before compilation (tracker run 35310749623).
Repair
Local validation
Remote Android unit tests and full release APK assembly are being run by this PR. No merge, signing, publication, or upstream.pin advance is included.