Repository navigation
fix: restore Android builds on Signal v8.28.0 - #22
Conversation
Port downstream settings to upstream Kotlin without changing stored keys, defaults, backup inclusion or theme notifications. Preserve the new neutralFill colors and existing patch provenance. Exercise settings and theme lifecycle tests in PR and release builds. Signed-off-by: amber <amber@flourish.ch>
Preserve plaintext language settings and upstream resource removal while retaining Vesper theme and backup controls. Adapt the Kotlin subscription response and initialise plaintext settings in the profile lifecycle fixture. Export the source commits using tools/export.sh. Signed-off-by: amber <amber@flourish.ch>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 988918dfed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1 +1 @@ | |||
| signal=v8.26.3 | |||
| signal=v8.28.0 | |||
There was a problem hiding this comment.
The reviewed commit message has no Signed-off-by: trailer, while CONTRIBUTING.md:19-25 requires every commit to include a Developer Certificate of Origin sign-off. Add a trailer matching the commit author before merging.
AGENTS.md reference: AGENTS.md:L45-L45
Useful? React with 👍 / 👎.
|
Rechecked before merge: both commits contain author-matching DCO trailers, including reviewed head 988918d: Signed-off-by: amber amber@flourish.ch. The automated missing-sign-off finding is a false positive. Exact-head PR CI is successful; local release assembly, 12 Android regression tests, 45 tooling checks, and identical-tree clean pinned materialisation were verified. |
1 participant
Summary
Verification
Only the repair branch was pushed. This PR uses the existing unsigned artifact-only validation workflow; no release workflow was dispatched and nothing was published.