Remove the Linux cfg gate on the webserver runtime drop - #3344
Merged
Conversation
besauce
force-pushed
the
remove-webserver-runtime-gate
branch
from
August 10, 2026 15:39
981c54c to
7009059
Compare
zmerp
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the cfg gate in
ServerCoreContext::dropso the webserver runtime is dropped on all platforms instead of leaked on Linux.The gate came in as a direct commit (a80f384) with a comment saying the drop prevented SteamVR shutdown on Linux, but no linked issue or PR, so there is no record of what the original hang was. The webserver it was written against has since been replaced, and the hang does not reproduce on a current stack:
if let Some(runtime) = self.webserver_runtime.take()instead of a baretake(); its other change, a steam.exe filename check, is a no-op on Linux). Repeated launch/quit cycles with no client connected (Arch, 7900 XTX, SteamVR previous branch): no hang, exit time identical to a control build that leaks the runtime. Fix steam.exe crash (Access Violation 0xc0000005) during SteamVR exit #3331 (comment)Both test setups were on the SteamVR previous branch, not 2.16.
Isolated from #3331 (#3331 (comment)). Original proposal by @Roboct424.