Skip to content

Remove the Linux cfg gate on the webserver runtime drop - #3344

Merged
zmerp merged 1 commit into
alvr-org:masterfrom
besauce:remove-webserver-runtime-gate
Aug 10, 2026
Merged

Remove the Linux cfg gate on the webserver runtime drop#3344
zmerp merged 1 commit into
alvr-org:masterfrom
besauce:remove-webserver-runtime-gate

Conversation

@besauce

@besauce besauce commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Removes the cfg gate in ServerCoreContext::drop so the webserver runtime is dropped on all platforms instead of leaked on Linux.

The gate came in as a direct commit (a80f384) with a comment saying the drop prevented SteamVR shutdown on Linux, but no linked issue or PR, so there is no record of what the original hang was. The webserver it was written against has since been replaced, and the hang does not reproduce on a current stack:

Both test setups were on the SteamVR previous branch, not 2.16.

Isolated from #3331 (#3331 (comment)). Original proposal by @Roboct424.

@besauce besauce changed the title remove linux cfg gate on webserver runtime drop Remove the Linux cfg gate on the webserver runtime drop Aug 4, 2026
@besauce
besauce force-pushed the remove-webserver-runtime-gate branch from 981c54c to 7009059 Compare August 10, 2026 15:39
@zmerp
zmerp added this pull request to the merge queue Aug 10, 2026
Merged via the queue into alvr-org:master with commit 779e553 Aug 10, 2026
12 checks passed
@besauce
besauce deleted the remove-webserver-runtime-gate branch August 16, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants