Skip to content

Paste Error Bugfix#1080

Open
ggalileo wants to merge 3 commits into
alohaeditor:devfrom
ggalileo:ctct-paste-errors
Open

Paste Error Bugfix#1080
ggalileo wants to merge 3 commits into
alohaeditor:devfrom
ggalileo:ctct-paste-errors

Conversation

@ggalileo

@ggalileo ggalileo commented Feb 6, 2014

Copy link
Copy Markdown
Contributor

This pull request adds an exception handler for the paste() call and only write to console.error if it exists.

This code has been tested across browsers by our QE.

  1. obey coding guidelines
  2. write JSLint compliant code
  3. write JSDoc for every method you touched during your implementation
  4. write a human-readable :) Changelog entry that describes your change
  5. add a qunit test (if it makes sense) and/or document the steps to manually test it (in a separate guides page)
  6. test your changes in Internet Explorer 7, 8, 9 and the latest Firefox and latest Chrome
  7. document your changes in a guides page
  8. include this list in a your pull request

@Jotschi

Jotschi commented Feb 7, 2014

Copy link
Copy Markdown
Contributor

Code looks good. Changelog should be "paste-plugin:" and not "Paste Plugin". I think we can deal with that during releasing.

@GenticsDev

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@Jotschi

Jotschi commented Feb 19, 2014

Copy link
Copy Markdown
Contributor

Admin please build this request

@GenticsDev

Copy link
Copy Markdown
Contributor

Test FAILed.
Refer to this link for build results: http://jenkins.office:8080/job/alohaeditor-upstream-pullrequests/6/

@Jotschi

Jotschi commented Feb 19, 2014

Copy link
Copy Markdown
Contributor

Admin please build this request

@GenticsDev

Copy link
Copy Markdown
Contributor

Test PASSed.
Refer to this link for build results: http://jenkins.office:8080/job/alohaeditor-upstream-pullrequests/15/

@petrosalema

Copy link
Copy Markdown
Member

@ggalileo what exceptions are raised during paste? Are you catching exceptions in the event that <script> elements are pasted into the content?

@ggalileo

ggalileo commented Mar 4, 2014

Copy link
Copy Markdown
Contributor Author

The errors from the bug report in the defect said that these two errors were seen in IE

  • SCRIPT5022: DOMException: INDEX_SIZE_ERR
  • Error: Access is denied

The actual pasted content was not included in the defect. Unfortunately, the developer who made this fix is no longer with us.

@GenticsDev

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

1 similar comment
@GenticsDev

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants