FIX: Remove nullptr dereference from aliceVision_multiview#2115
Open
philippremy wants to merge 1 commit intoalicevision:developfrom
Open
FIX: Remove nullptr dereference from aliceVision_multiview#2115philippremy wants to merge 1 commit intoalicevision:developfrom
philippremy wants to merge 1 commit intoalicevision:developfrom
Conversation
There is a guaranteed nullptr dereference in aliceVision_multiview, because TriangulationSphericalKernel::fitLS is at least called once with the default nullptr argument (from iterativeReweightedLeastSquares() and localOptimization()), which is unconditionally dereferenced. While not always causing an invalid access, it is UB and was identified as such by LLVM UBSanitizer. If we pass down the pointer to the very end, it is properly null-checked. Signed-off-by: Philipp Remy <philipp@philippremy.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a guaranteed nullptr dereference in aliceVision_multiview, because
TriangulationSphericalKernel::fitLS()is at least called once with the defaultnullptrargument (fromiterativeReweightedLeastSquares()andlocalOptimization()), which is unconditionally dereferenced.While not always causing an invalid access, it is UB and was identified as such by LLVM UBSanitizer. If we pass down the pointer to the very end, it is properly null-checked.