FIX: Add default virtual destructors to various abstract classes#2114
Open
philippremy wants to merge 1 commit intoalicevision:developfrom
Open
FIX: Add default virtual destructors to various abstract classes#2114philippremy wants to merge 1 commit intoalicevision:developfrom
philippremy wants to merge 1 commit intoalicevision:developfrom
Conversation
The missing virtual dtors caused a SIGTRAP on macOS. Calling delete on abstract classes is UB, which is hereby removed. Additionally silences a bunch of warnings emitted by Clang. Signed-off-by: Philipp Remy <philipp@philippremy.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The missing virtual dtors caused a
SIGTRAPon macOS. Callingdeleteon abstract classes is UB, which is hereby removed. I suspect that theSIGTRAPis caused by a memory alignment mismatch because the wrong dtor is running.Additionally silences a bunch of warnings emitted by Clang.