Skip to content

feat: use consistent iterable var naming conventions instead of the g… - #104

Merged
alexanderharding merged 1 commit into
mainfrom
iterable-var-naming
Aug 16, 2026
Merged

feat: use consistent iterable var naming conventions instead of the g…#104
alexanderharding merged 1 commit into
mainfrom
iterable-var-naming

Conversation

@alexanderharding

@alexanderharding alexanderharding commented Aug 16, 2026

Copy link
Copy Markdown
Owner

…eneric 'iterables'

Summary by CodeRabbit

  • New Features

    • Updated package versions for the all and for-of modules.
  • Refactor

    • Improved naming consistency and clarity across observable iteration APIs.
    • Clarified handling of observable collections without changing runtime behavior.
  • Tests

    • Updated test fixtures and variable names for improved readability.

@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1eec8ef1-c3d2-413b-91a0-0e13f6276c63

📥 Commits

Reviewing files that changed from the base of the PR and between ff7a61e and ec04228.

📒 Files selected for processing (5)
  • all/deno.json
  • all/mod.test.ts
  • all/mod.ts
  • for-of/deno.json
  • for-of/mod.ts

Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The PR renames iterable parameters in all and forOf, updates all to use its bounded observable collection consistently, adjusts one test fixture, and increments both package versions.

Changes

all iterable handling

Layer / File(s) Summary
Bounded observable iteration
all/mod.ts, all/mod.test.ts, all/deno.json
The all implementation uses observables and boundObservables consistently. The empty-iterable test uses the updated fixture name and type. The package version changes to 0.22.0.

forOf parameter update

Layer / File(s) Summary
forOf values parameter
for-of/mod.ts, for-of/deno.json
The forOf parameter changes from iterable to values. Validation and iteration behavior remain unchanged. The package version changes to 0.10.0.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to ec042

This is a localized naming update with related test and configuration adjustments; no actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: standardizing iterable variable naming conventions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch iterable-var-naming

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@alexanderharding
alexanderharding merged commit 600ec9c into main Aug 16, 2026
2 checks passed
@alexanderharding
alexanderharding deleted the iterable-var-naming branch August 16, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant