feat(httproute): add Gateway API HTTPRoute support#5447
Conversation
Signed-off-by: abelhoula <ahmd.belhoula@gmail.com>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: abelhoula <ahmd.belhoula@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5447 +/- ##
==========================================
+ Coverage 55.07% 55.99% +0.92%
==========================================
Files 426 423 -3
Lines 31528 32131 +603
==========================================
+ Hits 17363 17991 +628
+ Misses 13161 13087 -74
- Partials 1004 1053 +49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Hidde Beydals <hiddeco@users.noreply.github.com>
Co-authored-by: Hidde Beydals <hiddeco@users.noreply.github.com>
|
@abelhoula thanks for working on this and for your patience waiting for an in-depth review. I think this is a really worthwhile feature, ideally, I'd like to see this land in v1.11.0. My main ask would be for better parity with what's already supported with So, basically, what I'm saying is instead of Other varied feedback I have is more targeted, so I'll leave comments inline with the diffs. |
| httproute: | ||
| ## @param api.httproute.enabled Whether to enable HTTPRoute by creating an HTTPRoute resource. By default, this is disabled. Enabling HTTPRoute is advanced usage. | ||
| ## @param externalWebhooksServer.httproute.enabled -- Enable Gateway API HTTPRoute. | ||
| ## Gateway API support is in EXPERIMENTAL status. Support depends on your Gateway controller implementation. |
There was a problem hiding this comment.
I think it's GA now, but you can double-check me on that.
| ## @param externalWebhooksServer.httproute.enabled -- Enable Gateway API HTTPRoute. | ||
| ## Gateway API support is in EXPERIMENTAL status. Support depends on your Gateway controller implementation. | ||
| ## See the [Gateway API documentation](https://gateway-api.sigs.k8s.io/) for details. By default, this is disabled. | ||
| enabled: false |
There was a problem hiding this comment.
Somewhere in the comment above, it may be worth mentioning that setting this to true requires you to have the Gateway API CRDs installed on your cluster.
| ## @param externalWebhooksServer.ingress.pathType You may want to use `Prefix` for some controllers (like AWS LoadBalancer Ingress controller), which don't support `/` as wildcard path when pathType is set to `ImplementationSpecific` | ||
| pathType: ImplementationSpecific | ||
|
|
||
| httproute: |
There was a problem hiding this comment.
Same comments from the other httproute section apply here as well.
| parentRefs: | ||
| {{- with .Values.api.httproute.parentRefs }} | ||
| {{- toYaml . | nindent 4 }} | ||
| {{- end }} |
There was a problem hiding this comment.
I would suggest doing it like this so that empty/undefined .Values.api.httproute.parentRefs doesn't leave us with a key without a value here.
| parentRefs: | |
| {{- with .Values.api.httproute.parentRefs }} | |
| {{- toYaml . | nindent 4 }} | |
| {{- end }} | |
| {{- with .Values.api.httproute.parentRefs }} | |
| parentRefs: | |
| {{- toYaml . | nindent 4 }} | |
| {{- end }} |
|
This is an enhancement I'm really supportive of if/when the feedback's been addressed. I'll leave it open, but I'm removing it from the v1.11.0 milestone since this is not critical for that release and progress on the PR seems to have stalled. @abelhoula if you don't intend to resume work on this, please let me know so I have find someone else to take it over. |
No description provided.