Repository navigation
Support PostgreSQL and make the setup timeout configurable - #125
Merged
Merged
Conversation
Running the images against PostgreSQL never worked (akaunting/akaunting#3414): - The Debian images compiled pdo_mysql but not pdo_pgsql, and the Alpine images installed the plain pgsql extension, which Laravel cannot use. pdo_pgsql is now built in all seven images. - Setup gave up after 30 seconds, which is too short for a database that starts slowly, e.g. on Kubernetes. AKAUNTING_SETUP_TIMEOUT and AKAUNTING_SETUP_RETRY_INTERVAL now control this, with the old values as defaults. The retry loop also never printed "Unable to find database!": under bash -e, `(( retry_for -= retry_interval ))` reaching 0 returned 1 and ended the script first. The decrement is now an assignment. The number of attempts and the exit code are unchanged. Existing MySQL/MariaDB installations behave exactly as before. Refs akaunting/akaunting#3414, akaunting/akaunting#3422
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the images against PostgreSQL never worked (akaunting/akaunting#3414):
The retry loop also never printed "Unable to find database!": under bash -e,
(( retry_for -= retry_interval ))reaching 0 returned 1 and ended the script first. The decrement is now an assignment. The number of attempts and the exit code are unchanged.Existing MySQL/MariaDB installations behave exactly as before.
Refs akaunting/akaunting#3414, akaunting/akaunting#3422